Make files settings admin configurable

[bromiesTM]

Summary

• This gives an admin the ability to override user settings for the file app. For example, to always show hidden files.
• Adds unitests for https://github.com/nextcloud/server/blob/master/apps/files/lib/Service/UserConfig.php
• Fixes a bug where the "Invalid config value" exception is never thrown

To set the config run

ooc config:app:set --value <yes/no> files crop_image_previews
ooc config:app:set --value <yes/no> files show_hidden
ooc config:app:set --value <yes/no> files sort_favorites_first
ooc config:app:set --value <yes/no> files sort_folders_first
ooc config:app:set --value <yes/no> files grid_view
ooc config:app:set --value <yes/no> files folder_tree

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[bromiesTM]

🚧 Switched back to draft to make the settings less aggressive

[skjnldsv]

If the admin changed a value and override it, it's imperative the user is made aware of it.

[ArtificialOwl]

Can this be replaced by #49399 ?

nevermind: the lexicon does not offer admin configuration for default user preferences

[ArtificialOwl]

Hello @bromiesTM

We might have an other simpler way of implementing this feature.
From what I understand you want admins to be able to:

• set a specific default value for a specific user preferences config key,
• this value does not overwrite eventual value set by your users,
• this value can be overwritten by your users when setting their own value.

If this is the case, we have an easier way to do this for 31

[printminion-co]

Hello @bromiesTM

We might have an other simpler way of implementing this feature. From what I understand you want admins to be able to:

• set a specific default value for a specific user preferences config key,
• this value does not overwrite eventual value set by your users,
• this value can be overwritten by your users when setting their own value.

If this is the case, we have an easier way to do this for 31

is it documented somewhere? In order to us to check it?

[ArtificialOwl]

I just wanted to know if my description fit the expected behavior.

This is the PR: #49848 but I have not started yet any discussion with other engineer if we really want the feature and if it can be implemented this way ...

If we merge in this current state, the files app will need to implement the IConfigLexicon feature and include the config keys listed above

[skjnldsv]

@bromiesTM @printminion-co the question is: do you want to enforce the user settings or just charge the defaults (but still let the user change it)

[printminion-co]

@bromiesTM @printminion-co the question is: do you want to enforce the user settings or just charge the defaults (but still let the user change it)

We started with "enforce the user settings" but in this way the user was not able to switch the "grid_view"

That is why we (not yet in this PR) do the "just charge the defaults (but still let the user change it)"
Also we removed UI (not in this PR) to change the files app values (e.g. show_hidden).

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[bromiesTM]

As the IConfigLexicon would allow doing the same, we decided to close this PR.
The Unit Tests and type checking bugfix will be provided via another PR #50050