Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(occ): Better handling of disabled or unreacheable App store #49697

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(occ): Better handling of disabled or unreacheable App store #49697

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Dec 6, 2024 •
edited
Loading

Summary

Set either appstoreenabled or has_internet_connection to false on config.php file.

Previously in all cases:

# occ app:update previewgenerator
previewgenerator is up-to-date or no updates could be found

After:

# occ app:update previewgenerator
App store access is disabled

or

# occ app:update previewgenerator
Internet connection is disabled, and therefore the default public App store is not reachable

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Dec 6, 2024
@solracsf solracsf added this to the Nextcloud 31 milestone Dec 6, 2024
@solracsf
feat(occ): Better handling of disabled or unreacheable App store
bcc9d07 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the appStoreDisabledOcc branch from 24a5bfc to bcc9d07 Compare December 16, 2024 14:24
@solracsf
Copy link
Member Author

/backport to stable30

@solracsf
Copy link
Member Author

/backport to stable29

@solracsf solracsf requested review from a team, ArtificialOwl, icewind1991, yemkareems, provokateurin and come-nc and removed request for a team December 16, 2024 14:25
@solracsf solracsf changed the title feat(occ): Better handling of disabled appstore message feat(occ): Better handling of disabled or unreacheable App store Dec 16, 2024
@solracsf solracsf enabled auto-merge December 16, 2024 14:27
provokateurin
provokateurin reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add two tests for this?

@blizzz blizzz mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin left review comments

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems was automatically assigned from nextcloud/server-backend

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request feature: apps management feature: occ
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
3 participants
@solracsf @provokateurin @come-nc