Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): Stop infinite loop blocking link share requests #49442

Merged
merged 2 commits into from
Dec 9, 2024
Merged

fix(files_sharing): Stop infinite loop blocking link share requests #49442

merged 2 commits into from
Dec 9, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 22, 2024 •
edited
Loading

  • fix(files_sharing): Stop infinite loop blocking link share requests

      Fixes infinite loop preventing share link creation requests from being sent to the backend.

  • fix: Delete link update code in ShareEntryLink

      Since Nexcloud27, all share edits can only be done from the `SharingDetailsTab` or the `QuickShareSelect` so this concerned component does not need to handle updates.

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from a73510b to ea48600 Compare December 3, 2024 15:38
@nfebe
Copy link
Contributor Author

nfebe commented Dec 5, 2024

This should resolve : #49678

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch 3 times, most recently from 1894862 to c2f1a91 Compare December 5, 2024 22:24
@nfebe
Copy link
Contributor Author

nfebe commented Dec 5, 2024

/compile

@nfebe nfebe marked this pull request as ready for review December 5, 2024 22:25
@nfebe nfebe requested review from skjnldsv and Pytal December 5, 2024 22:25
@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from c2f1a91 to 9361ec6 Compare December 5, 2024 22:28
@nfebe
Copy link
Contributor Author

nfebe commented Dec 5, 2024 •
edited by solracsf
Loading

/backport to stable30

@nfebe
Copy link
Contributor Author

nfebe commented Dec 5, 2024

/backport to stable28

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch 2 times, most recently from 83cda71 to 8b68f3d Compare December 5, 2024 22:47
@nfebe
Copy link
Contributor Author

nfebe commented Dec 5, 2024

/compile

@nfebe nfebe changed the title fix(files_sharing): Resolve race condition blocking link share requests fix(files_sharing): Stop infinite loop blocking link share requests Dec 5, 2024
@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from 8b68f3d to 4361649 Compare December 5, 2024 22:51
@nfebe nfebe linked an issue Dec 5, 2024 that may be closed by this pull request
[Bug]: 30.0.3 share link completely broken #49678
Closed
8 tasks
Pytal
Pytal approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@Pytal
Copy link
Member

Pytal commented Dec 5, 2024

Only see backports for 30 + 28, I guess #49115 should also be on 29?

@Pytal
Copy link
Member

Pytal commented Dec 5, 2024

Seems partially fixed but the behaviour is unexpected

When clicking the + button, instead of creating the share like before it opens a menu so you have to click "Add another link" to actually create it
image
image

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from 4361649 to e2468db Compare December 6, 2024 01:49
@nfebe
Copy link
Contributor Author

nfebe commented Dec 6, 2024

Seems partially fixed but the behaviour is unexpected

When clicking the + button, instead of creating the share like before it opens a menu so you have to click "Add another link" to actually create it

Should work now properly for all these cases:

  • Default password set but not enforced, and no default expiration date set.
  • Default password set and enforced, and no default expiration date set.
  • Default expiration date set but not enforced, and default password not set and therefore not enforced.
  • Default expiration date set and enforced, and default password not set and therefore not enforced.
  • Default password set but not enforced, and default expiration date set but not enforced.
  • Default password set but not enforced, and default expiration date set and enforced.
  • Default password set and enforced, and default expiration date set but not enforced.
  • Default password set and enforced, and default expiration date set and enforced.

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from e2468db to 6116a63 Compare December 6, 2024 02:25
@nfebe
Copy link
Contributor Author

nfebe commented Dec 6, 2024

/compile

@solracsf solracsf requested a review from Pytal December 6, 2024 10:55
@solracsf
Copy link
Member

solracsf commented Dec 6, 2024

/backport to stable30

@solracsf
Copy link
Member

solracsf commented Dec 6, 2024

/backport to stable29

@blizzz
Copy link
Member

blizzz commented Dec 6, 2024

/backport to stable28

@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch 7 times, most recently from 35a8d0a to 776e376 Compare December 9, 2024 00:24
@nfebe
Copy link
Contributor Author

nfebe commented Dec 9, 2024

/compile

nfebe and others added 2 commits December 9, 2024 01:40
@nfebe
fix(files_sharing): Stop infinite loop blocking link share requests
e7dc141 
Fixes infinite loop preventing share link creation requests
from being sent to the backend.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nextcloud-command @nfebe
chore(assets): Recompile assets
290f9da 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nfebe nfebe force-pushed the fix/no-issue/link-sharing-defaults branch from 4c74e98 to 290f9da Compare December 9, 2024 00:41
@nfebe nfebe merged commit 6f3ee6b into master Dec 9, 2024
120 checks passed
@nfebe nfebe deleted the fix/no-issue/link-sharing-defaults branch December 9, 2024 00:53
This was referenced Dec 9, 2024
Merged
Merged
Merged
@blizzz blizzz mentioned this pull request Dec 9, 2024
Closed
8 tasks
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorbaugh sorbaugh sorbaugh approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 30.0.3 share link completely broken
6 participants
@nfebe @Pytal @solracsf @blizzz @sorbaugh @nextcloud-command