fix(files): File type filter UI sync with filter state #49259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable30 |
|
/compile |
Pytal
reviewed
Nov 13, 2024
apps/files/src/components/FileListFilter/FileListFilterType.vue
Outdated
Show resolved
Hide resolved
When changing the folder the filter will be re-mounted by the file list, so we need to pass the current state of the filter to the filter UI. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/file-type-filter-state
branch
from
67ed7d5 to
7be3fd3
Compare
Pytal
reviewed
Dec 3, 2024
| @@ -71,6 +75,10 @@ export default defineComponent({ | |||
| }, | |||
|
|
|||
| watch: { | |||
| /** Reset selected options if property is changed */ | |||
| preset() { | |||
There was a problem hiding this comment.
Suggested change
| preset() { | |
| presets() { |
Looks like the prop was renamed to presets
| @@ -142,7 +144,8 @@ class TypeFilter extends FileListFilter { | |||
| } | |||
|
|
|||
| public setPreset(presets?: ITypePreset[]) { | |||
| this.currentPresets = presets | |||
| this.currentPresets = presets ?? [] | |||
| this.currentInstance!.$props.preset = presets | |||
There was a problem hiding this comment.
Suggested change
| this.currentInstance!.$props.preset = presets | |
| this.currentInstance!.$props.presets = presets |
Same as above
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When changing the folder the filter will be re-mounted by the file list, so we need to pass the current state of the filter to the filter UI.
Checklist