Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS: do not query CNAME if A succeeded already #48675

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

georglauterbach
Copy link

Fixes: #48048

Summary

When an A query succeeds, querying for CNAME again is

  1. useless at best, and
  2. creating unnecessary log entries in the DNS server.

Checklist

Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
@solracsf

This comment was marked as resolved.

Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
@georglauterbach
Copy link
Author

Tests are failing:

I hope that is fixed with e3d7d84; I am not a PHP programmer, though; hence, I am not sure whether assertNotContains is used correctly here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: DNS CNAME record is always queried, even when the query for an A record already succeeded
2 participants