Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http client): expose default request timeout constant to be used instead of magic number 30 #48639

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

tcitworld
Copy link
Member

Will be used to set default where we are able to override the default timeout.

See #48418

Checklist

@tcitworld tcitworld added 3. to review Waiting for reviews php Pull requests that update Php code labels Oct 10, 2024
@tcitworld tcitworld added this to the Nextcloud 31 milestone Oct 10, 2024
@tcitworld tcitworld requested review from kesselb, pabzm, a team, nfebe, skjnldsv and yemkareems and removed request for a team October 10, 2024 05:56
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@kesselb
Copy link
Contributor

kesselb commented Oct 10, 2024

The unconventional commits check is failing. Maybe a space in the scope is not valid?

Could also use the new constant here:

$this->timeout = Server::get(IConfig::class)->getSystemValueInt('davstorage.request_timeout', 30);

… instead of magic number 30

Will be used to set default where we are able to override the default timeout.

See #48418

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld force-pushed the add-default-request-timeout-const branch from b42bca1 to dcd27fd Compare October 11, 2024 08:57
@tcitworld tcitworld merged commit 205af79 into master Oct 11, 2024
177 checks passed
@tcitworld tcitworld deleted the add-default-request-timeout-const branch October 11, 2024 10:10
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feedback-requested php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants