refactor(Storage): Align all Storage constructors #48614
+154
−221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
approved these changes
Oct 8, 2024
Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
refactor/storage/constructors
branch
from
ccf70fc
to
61b97dd
Compare
provokateurin
requested review from
a team,
ArtificialOwl,
icewind1991 and
artonge
and removed request for
a team
artonge
reviewed
Oct 14, 2024
Comment on lines
-18
to
-21
| * @param array $arguments ['storage' => $storage, 'owner' => $owner] | ||
| * | ||
| * $storage: The storage the permissions mask should be applied on | ||
| * $owner: The owner to use in case no owner is found |
There was a problem hiding this comment.
Why remove comments and type indications?
There was a problem hiding this comment.
If we want to do this right then it needs proper psalm annotations instead of this.
I don't know if this comment is really helpful in the current state.
There was a problem hiding this comment.
Well, it explains the expected data format, and it's purpose, so I would say it is useful.
There was a problem hiding this comment.
But we also have the problem that the parameters are passed to the parent class.
So if we limit the types using psalm, then a valid input that is only read by the parent class might get rejected.
There was a problem hiding this comment.
I haven't checked, I just wanted to say that it can be a problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds strong types, removes wrong doc blocks and uses the same parameter name everywhere.
Checklist