Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rector): Extend scope to all PHP files #48355

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −7
Draft

refactor(rector): Extend scope to all PHP files #48355

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions build/rector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,19 @@
$config = RectorConfig::configure()
->withPaths([
$nextcloudDir . '/apps',
// $nextcloudDir . '/config',
// $nextcloudDir . '/core',
// $nextcloudDir . '/lib',
// $nextcloudDir . '/ocs',
// $nextcloudDir . '/ocs-provider',
// $nextcloudDir . '/tests',
// $nextcloudDir . '/themes',
$nextcloudDir . '/build',
$nextcloudDir . '/config',
$nextcloudDir . '/core',
$nextcloudDir . '/lib',
$nextcloudDir . '/ocs',
$nextcloudDir . '/ocs-provider',
$nextcloudDir . '/tests',
$nextcloudDir . '/themes',
$nextcloudDir . '/*.php',
Comment on lines +17 to +25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do so please add them one by one with the commit applying the result to the folder.
But I would prefer to apply more rules to apps folder instead.
Maybe we should have 2 rector config, one for apps and one for core/lib?
We can have matching rector scripts in composer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate configs sounds good 👍

])
->withSkip([
$nextcloudDir . '/build/stubs/*',
$nextcloudDir . '/lib/composer/*',
$nextcloudDir . '/apps/*/3rdparty/*',
$nextcloudDir . '/apps/*/build/stubs/*',
$nextcloudDir . '/apps/*/composer/*',
Expand Down
Loading