feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

susnux · 2024-09-16T14:44:30Z

Fix #41037

Summary

This contains multiple "things":

❇️ Allow GET on folders to download them
- if no accept header for ZIP is sent then (for browser download) allow GET params but if nothing set then fallback to Sabre -> should be non-breaking
🐛 This now also allows downloading "select-multiple" files form e.g. "recent" or "favorites" view where the files are not really located in the same folder.

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php

…ng GET requests Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

… UA handling Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

…endpoint Folllow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

…endpoint Follow-up of nextcloud#48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

susnux added the 3. to review Waiting for reviews label Sep 16, 2024

susnux requested a review from come-nc September 16, 2024 14:44

susnux added bug enhancement feature: files labels Sep 16, 2024

susnux added this to the Nextcloud 31 milestone Sep 16, 2024

susnux marked this pull request as ready for review September 16, 2024 15:35

susnux requested a review from skjnldsv as a code owner September 16, 2024 15:35

github-advanced-security bot found potential problems Sep 16, 2024

View reviewed changes

susnux force-pushed the feat/zip-folder-plugin branch from 8b6c19d to 2e3dd35 Compare September 16, 2024 15:56

github-advanced-security bot found potential problems Sep 16, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Dismissed Show dismissed Hide dismissed

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Fixed Show fixed Hide fixed

come-nc reviewed Sep 16, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Outdated Show resolved Hide resolved

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Outdated Show resolved Hide resolved

susnux force-pushed the feat/zip-folder-plugin branch 2 times, most recently from 197f151 to 6c97ecf Compare September 16, 2024 23:56

skjnldsv reviewed Sep 17, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Show resolved Hide resolved

come-nc reviewed Sep 17, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Outdated Show resolved Hide resolved

skjnldsv reviewed Sep 17, 2024

View reviewed changes

apps/dav/lib/Connector/Sabre/ZipFolderPlugin.php Outdated Show resolved Hide resolved

skjnldsv mentioned this pull request Sep 17, 2024

Honor Accept header when downloading directories #41037

Closed

susnux requested review from come-nc, provokateurin and skjnldsv September 18, 2024 16:31

come-nc approved these changes Sep 19, 2024

View reviewed changes

skjnldsv approved these changes Sep 19, 2024

View reviewed changes

come-nc force-pushed the feat/zip-folder-plugin branch from 6532ccb to 37741d5 Compare September 20, 2024 15:31

susnux force-pushed the feat/zip-folder-plugin branch 4 times, most recently from 62a1afa to 7a29e55 Compare September 26, 2024 23:28

susnux added 2 commits September 28, 2024 13:18

feat(dav): New ZipFolderPlugin which allows to download folders usi…

d66e16b

…ng GET requests Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

fix: Allow Streamer to specify type in constructor instead of magin…

2f66bd5

… UA handling Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux added 2 commits September 28, 2024 13:18

chore: Drop unused legacy OC_Files

eb69e89

It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

chore: compile assets

ca8d576

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

susnux force-pushed the feat/zip-folder-plugin branch from 7a29e55 to ca8d576 Compare September 28, 2024 12:01

susnux merged commit 31ad1c5 into master Sep 28, 2024
173 checks passed

susnux deleted the feat/zip-folder-plugin branch September 28, 2024 12:24

susnux mentioned this pull request Sep 28, 2024

chore(developer): Add documentation about new WebDAV endpoint for downloading folders nextcloud/documentation#12247

Merged

This was referenced Sep 28, 2024

CI fix: app_api is now bundled app from NC 30.0.1 cloud-py-api/nc_py_api#303

Merged

Fix of download_directory_as_zip function for NC31 cloud-py-api/nc_py_api#304

Merged

provokateurin mentioned this pull request Sep 30, 2024

fix(psalm): Update baseline #48453

Merged

4 tasks

joshtrichards mentioned this pull request Nov 9, 2024

[Bug]: Downloading multiple Files from recent Files in webgui results in empty Zip #48708

Closed

8 tasks

skjnldsv mentioned this pull request Jan 7, 2025

31.0.0 beta 1 #50066

Merged

susnux mentioned this pull request Feb 5, 2025

[Bug]: Invalid zip created when downloading several files at once #38335

Closed

9 tasks

come-nc mentioned this pull request Feb 27, 2025

[Bug]: NC31.0.0 not logging view/download activity #51097

Closed

8 tasks

skjnldsv mentioned this pull request Mar 27, 2025

fix(files): Properly encode URLs when preparing ZIP download #51684

Merged

2 tasks

artonge added a commit that referenced this pull request May 14, 2025

fix: Replace the deprecated direct download link with the public DAV …

5dd4e5a

…endpoint Folllow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 14, 2025

fix: Replace the deprecated direct download link with the public DAV …

62b6c7e

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 16, 2025

fix: Replace the deprecated direct download link with the public DAV …

cc047b2

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 19, 2025

fix: Replace the deprecated direct download link with the public DAV …

7b1d3a7

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 19, 2025

fix: Replace the deprecated direct download link with the public DAV …

cb391f8

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 19, 2025

fix: Replace the deprecated direct download link with the public DAV …

e10bf4f

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 20, 2025

fix: Replace the deprecated direct download link with the public DAV …

8a1e597

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 21, 2025

fix: Replace the deprecated direct download link with the public DAV …

11a45b6

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 21, 2025

fix: Replace the deprecated direct download link with the public DAV …

0eef221

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 21, 2025

fix: Replace the deprecated direct download link with the public DAV …

d5be952

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

artonge added a commit that referenced this pull request May 21, 2025

fix: Replace the deprecated direct download link with the public DAV …

ec1db0c

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

backportbot bot pushed a commit that referenced this pull request May 22, 2025

fix: Replace the deprecated direct download link with the public DAV …

617af2f

…endpoint Follow-up of #48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

mickenordin pushed a commit to mickenordin/server that referenced this pull request May 23, 2025

fix: Replace the deprecated direct download link with the public DAV …

5b8688b

…endpoint Follow-up of nextcloud#48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

joshtrichards mentioned this pull request Jun 3, 2025

Allow web browsers to cache publicly shared files #45399

Open

AIlkiv pushed a commit to AIlkiv/server that referenced this pull request Jul 10, 2025

fix: Replace the deprecated direct download link with the public DAV …

fb4dde4

…endpoint Follow-up of nextcloud#48098 Signed-off-by: Louis Chemineau <louis@chmn.me>

printminion-co mentioned this pull request Jul 29, 2025

File Download limit not decreasing nextcloud/files_downloadlimit#501

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

Uh oh!

susnux commented Sep 16, 2024 •

edited by skjnldsv

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

feat: Move to ZipFolderPlugin for downloading multiple-nodes #48098

Uh oh!

Conversation

susnux commented Sep 16, 2024 • edited by skjnldsv Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

susnux commented Sep 16, 2024 •

edited by skjnldsv

Loading