-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove OCP\Files\Storage interface deprecated since version 9 #48009
Merged
come-nc
merged 9 commits into
master
from
fix/remove-references-to-deprected-storage-interface
Sep 16, 2024
Merged
fix: Remove OCP\Files\Storage interface deprecated since version 9 #48009
come-nc
merged 9 commits into
master
from
fix/remove-references-to-deprected-storage-interface
Sep 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/remove-references-to-deprected-storage-interface
branch
2 times, most recently
from
September 15, 2024 12:39
95bdfaf
to
619767a
Compare
come-nc
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Sep 15, 2024
skjnldsv
approved these changes
Sep 16, 2024
icewind1991
reviewed
Sep 16, 2024
icewind1991
reviewed
Sep 16, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…te Storage interface Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…to IStorage Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…salm-suppress Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-references-to-deprected-storage-interface
branch
from
September 16, 2024 16:11
f9cd67f
to
e7ac9bb
Compare
4 tasks
susnux
reviewed
Sep 16, 2024
susnux
approved these changes
Sep 16, 2024
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
the
pending documentation
This pull request needs an associated documentation update
label
Sep 16, 2024
4 tasks
come-nc
deleted the
fix/remove-references-to-deprected-storage-interface
branch
September 16, 2024 18:50
Thank you so much ! It's been super hard to dive into the code because of the amount of legacy stuff. I'm glad this part is gone 🥳 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
pending documentation
This pull request needs an associated documentation update
technical debt
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated interface and its last uses (mostly in tests).
Checklist