Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Adjust Cache::searchQuery() parameter name to match interface #47954

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Sep 13, 2024

Summary

public function searchQuery(ISearchQuery $query);

Checklist

…face

Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin provokateurin added this to the Nextcloud 31 milestone Sep 13, 2024
@provokateurin provokateurin requested a review from a team September 13, 2024 16:15
@provokateurin
Copy link
Member Author

/backport to stable30

@provokateurin
Copy link
Member Author

/backport to stable29

@provokateurin
Copy link
Member Author

/backport to stable28

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there no psalm warning for this?

@provokateurin
Copy link
Member Author

There is, but it was hidden by the baseline :/

@provokateurin
Copy link
Member Author

Can someone force merge? Cypress fails hard for unknown reason and this change can not possibly affect cypress results anyway.

@provokateurin provokateurin merged commit 80f3227 into master Sep 13, 2024
174 checks passed
@provokateurin provokateurin deleted the fix/files/cache-search-query-parameter-name branch September 13, 2024 16:59
Copy link

backportbot bot commented Sep 13, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/47954/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 714671a8

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/47954/stable29

Error: Failed to push branch backport/47954/stable29: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@provokateurin
Copy link
Member Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants