Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(caldav): create subscriptions via occ #47916

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Sep 12, 2024

Summary

Allow adding subscriptions via OCC

TODO

  • Docs

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Sep 12, 2024
@miaulalala miaulalala added this to the Nextcloud 31 milestone Sep 12, 2024
@miaulalala miaulalala self-assigned this Sep 12, 2024
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inject the CalDavBackend to get rid of all the service locators

Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be nice to execute subscription sync to test is the URL is valid?

apps/dav/lib/Command/CreateSubscription.php Outdated Show resolved Hide resolved
@miaulalala
Copy link
Contributor Author

Could be nice to execute subscription sync to test is the URL is valid?

I did have that initially, but since it's quite a lot of code duplication I desisted from doing that as it's not really neccessary. The RefreshWebCal Job will log if the url isn't valid.

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the feat/add-subscription-via-occ branch from e36071d to 1f00cef Compare September 15, 2024 17:11
@miaulalala miaulalala merged commit 5a8d0a2 into master Sep 15, 2024
174 checks passed
@miaulalala miaulalala deleted the feat/add-subscription-via-occ branch September 15, 2024 18:24
@miaulalala miaulalala added the pending documentation This pull request needs an associated documentation update label Oct 2, 2024
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

4 participants