-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(caldav): create subscriptions via occ #47916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inject the CalDavBackend to get rid of all the service locators
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be nice to execute subscription sync to test is the URL is valid?
I did have that initially, but since it's quite a lot of code duplication I desisted from doing that as it's not really neccessary. The RefreshWebCal Job will log if the url isn't valid. |
Signed-off-by: Anna Larch <anna@nextcloud.com>
e36071d
to
1f00cef
Compare
Summary
Allow adding subscriptions via OCC
TODO
Checklist