Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(setup-checks): Ensure URL with webroot works #47883

Merged
merged 2 commits into from
Sep 13, 2024
Merged

fix(setup-checks): Ensure URL with webroot works #47883

merged 2 commits into from
Sep 13, 2024
+311 −50

Commits on Sep 13, 2024

  1. fix(setup-checks): Ensure URL with webroot works 

    We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @kesselb
    susnux and kesselb committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9e979d4 View commit details
    Browse the repository at this point in the history

  2. refactor(settings): CheckServerResponseTrait always expect absolute… 

    … path

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux @come-nc
    susnux and come-nc committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    be1cd7a View commit details
    Browse the repository at this point in the history