attempt to add a meaningful user name to the from field of a calendar… #47684
Conversation
jpmg-mb
requested review from
ChristophWurst,
miaulalala and
tcitworld
as code owners
|
Please sign off your commit 🙏 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -194,6 +194,15 @@ | |||
|
|
|||
| $sender = substr($iTipMessage->sender, 7); | |||
|
|
|||
| /* if $senderName still NULL, see if userManager has a match | |||
| * for the sender email now it's been extracted ... */ | |||
| if ($senderName === null) { | |||
Check notice
Code scanning / Psalm
DocblockTypeContradiction Note
| /* if $senderName still NULL, see if userManager has a match | ||
| * for the sender email now it's been extracted ... */ | ||
| if ($senderName === null) { | ||
| $iumatches = $this->userManager->getByEmail($sender); |
Check failure
Code scanning / Psalm
UndefinedThisPropertyFetch Error
There was a problem hiding this comment.
This seems to be serious, I also see no userManager in this class.
… invite email Signed-off-by: Patrick Gosling <jpmg@mythic-beasts.com>
jpmg-mb
force-pushed
the
fix-invite-from-line
branch
from
0651c4c
to
ac18475
Compare
|
(now signed-off; apologies for failing to do so originally!) |
|
Hi @jpmg-mb Thank you for the pull request!! This should no longer be an issue... This should have been addressed by the following PR #45098 And should now be working... The following line... actually pulls the user name form the system... server/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php Lines 189 to 190 in 69f4a39 |
|
@SebastianKrupinski - thank you for looking at it! is that other patch going to get backported to v29? |
I don't see an issue with it... Just waiting for an answer from someone to make sure they don't have any objections |
Got a go ahead for this... I'll get it in this week |
|
I'm going to close this PR, as I've been able to verify that the existing fix mentioned above does indeed resolve the problem I wrote this to solve 8-) |
|
@jpmg-mb Thanks for testing and letting me know!!! I'm glad your issue is fixed. |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
When generating a calendar event invite email from an event generated within thu
nderbird or similar application, nextcloud generates a From line that does not i
dentify the person generating the invite. This patch makes a further attempt to
extract a real name and add it to the From line. I've been running this patch in
formally against most nextcloud versions from v25.0.4 onwards, and it has fixed
the issue, and not caused any observed problems.
@GalacticWave @SebastianKrupinski
[ apologies, 2nd attempt at a PR, based on master this time ]
TODO
Checklist