Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(files): Allow more than 50 favorite views #47400

Merged
merged 4 commits into from
Aug 27, 2024
Merged

feat(files): Allow more than 50 favorite views #47400

merged 4 commits into from
Aug 27, 2024

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Aug 21, 2024 •
edited
Loading

Summary

Technically this is a feature but could also be considered a fix. Favorites were being loaded with a hardcoded limit

server/apps/files/lib/Activity/Helper.php

Line 17 in c3ad469

public const FAVORITE_LIMIT = 50;
of 50, so once a user had >=50 favorites none would be loaded. To fix this we no longer block page load with the server-side retrieval and load them from the frontend instead.

Checklist

@Pytal Pytal added this to the Nextcloud 31 milestone Aug 21, 2024
@Pytal Pytal requested a review from a team August 21, 2024 17:37
@Pytal Pytal self-assigned this Aug 21, 2024
@Pytal Pytal requested a review from skjnldsv as a code owner August 21, 2024 17:37
@Pytal Pytal requested review from artonge and Fenn-CS and removed request for a team August 21, 2024 17:37
@Pytal Pytal enabled auto-merge August 21, 2024 17:39
@Pytal

This comment was marked as resolved.

Sign in to view
susnux
susnux approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Fix, cleanup and semi-feature 😄

@susnux susnux force-pushed the feat/load-more-than-50-faves branch 2 times, most recently from 4f911c4 to c887c14 Compare August 24, 2024 10:17
@susnux
Copy link
Contributor

susnux commented Aug 24, 2024

/backport to stable30

@susnux susnux force-pushed the feat/load-more-than-50-faves branch from c887c14 to 36c6fc6 Compare August 24, 2024 10:37
@Pytal Pytal force-pushed the feat/load-more-than-50-faves branch from 36c6fc6 to 7117356 Compare August 26, 2024 18:05
jancborchardt
jancborchardt approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

Pytal and others added 3 commits August 27, 2024 14:33
@Pytal @susnux
perf(files): Do not block files page load with server-side favorites …
71e653c 
…retrieval

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(files): Allow more than 50 favorite views
9cc1a02 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test(files): Adapt favorite views spec
a1f4396 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/load-more-than-50-faves branch from 7117356 to a1f4396 Compare August 27, 2024 22:39
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 27, 2024
@Pytal
Copy link
Member Author

Pytal commented Aug 27, 2024

/compile /

@nextcloud-command
chore(assets): Recompile assets
f48a7ff 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit b7212e3 into master Aug 27, 2024
171 checks passed
@Pytal Pytal deleted the feat/load-more-than-50-faves branch August 27, 2024 23:25
@backportbot backportbot bot mentioned this pull request Aug 27, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge artonge was automatically assigned from nextcloud/server-frontend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish bug enhancement feature: files
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.

[Bug]: Favorites in Files navigation not expandable anymore
5 participants
@Pytal @susnux @jancborchardt @skjnldsv @nextcloud-command