Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable auto-zoom on iOS #47371

Merged
merged 2 commits into from
Aug 21, 2024
Merged

fix: Disable auto-zoom on iOS #47371

merged 2 commits into from
Aug 21, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 21, 2024

Summary

When using iOS and focusing an input element the view should not be zoomed. So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom. But we can not do this by default as this will disable user zoom on Chrome.

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 21, 2024
@susnux susnux added this to the Nextcloud 31 milestone Aug 21, 2024
@susnux
Copy link
Contributor Author

susnux commented Aug 21, 2024

/backport to stable30

@susnux susnux requested a review from juliusknorr August 21, 2024 09:55
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, tested and works now 👍

Just Ci is not happy yet

susnux added 2 commits August 21, 2024 13:01
When using iOS and focussing an input element the view should not be zoomed.
So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom.
But we can not do this by default as this will disable user zoom on Chrome.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/disable-auto-zoom-ios branch from 0559c8d to c82b17d Compare August 21, 2024 11:01
@susnux
Copy link
Contributor Author

susnux commented Aug 21, 2024

/backport to stable30

@susnux susnux merged commit 1992a6d into master Aug 21, 2024
171 checks passed
@susnux susnux deleted the fix/disable-auto-zoom-ios branch August 21, 2024 12:32
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto zoom when using Nextcloud on Safari iOS
4 participants