Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook_listeners): Avoid collision between two identical calls at the same second #47061

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 6, 2024

Summary

The job list needs argument to be unique for each registered job, so add a random string on top of time to make sure the same call can be registered several times at the same second.

Checklist

…t the same second

The job list needs argument to be unique for each registered job, so add
 a random string on top of time to make sure the same call can be
 registered several times at the same second.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added bug 3. to review Waiting for reviews labels Aug 6, 2024
@come-nc come-nc added this to the Nextcloud 30 milestone Aug 6, 2024
@come-nc come-nc self-assigned this Aug 6, 2024
@Altahrim Altahrim mentioned this pull request Aug 6, 2024
@AndyScherzinger AndyScherzinger merged commit a455283 into master Aug 6, 2024
169 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/avoid-collision-of-webhook-calls branch August 6, 2024 18:17
@Altahrim Altahrim mentioned this pull request Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants