fix(settings): Don't permit duplicate groups in occ admin-delegation:add
#46617
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
joshtrichards
added
bug
3. to review
|
/backport to stable29 |
Merged
joshtrichards
changed the title
occ admin-delegation:add
joshtrichards
changed the title
occ admin-delegation:addocc admin-delegation:add
Merged
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
come-nc
reviewed
Oct 9, 2025
| $groups = $this->authorizedGroupService->findExistingGroupsForClass($settingClass); | ||
| foreach ($groups as $group) { | ||
| if ($group->getGroupId() === $groupId) { | ||
| $io->error('The specified group has already been delegated to.'); |
There was a problem hiding this comment.
This is not clear, it should say it has already been delegated the same setting or something, no?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist