Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add utility method to validate an IHasher hash #46186

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jun 27, 2024

Summary

Adds a method for validating that a hashed password has been hashed by IHasher::hash()

This can be used when the original plain text password is not known, otherwise IHasher::verify() should be used

Checklist

@Pytal Pytal added enhancement 3. to review Waiting for reviews labels Jun 27, 2024
@Pytal Pytal added this to the Nextcloud 30 milestone Jun 27, 2024
@Pytal Pytal requested review from come-nc and a team June 27, 2024 23:57
@Pytal Pytal self-assigned this Jun 27, 2024
@Pytal Pytal requested review from yemkareems and sorbaugh and removed request for a team June 27, 2024 23:57
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A unit test would be nice

Pytal added 3 commits July 4, 2024 17:05
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal enabled auto-merge July 5, 2024 00:10
@Pytal Pytal merged commit 915eef6 into master Jul 5, 2024
166 checks passed
@Pytal Pytal deleted the feat/validate-hash branch July 5, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants