Support profiler in occ commands #46169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes profiler event graph by removing an event start which had no matching end() call. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Commands will appear in available profiles after the command ran. Method is set to "occ" and URL to the command line with parameters. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
3. to review
come-nc
requested review from
a team,
ArtificialOwl,
yemkareems,
sorbaugh,
icewind1991,
Altahrim and
artonge
and removed request for
a team
artonge
approved these changes
Jul 1, 2024
icewind1991
approved these changes
Jul 1, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable the profiler for occ commands as well.
When profiler is enabled and debug is on, profiles for ran occ commands will also appear in the profiles list.
The Method is set to "occ" instead of an HTTP method and the URL field contains the command with its parameters instead.
Also fixed a problem in event logging about an application load event which was started twice with slightly different id and ended only once.
Checklist