Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FilesView): Update files view upon share creation/delete #46030

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

Fenn-CS
Copy link
Contributor

@Fenn-CS Fenn-CS commented Jun 21, 2024

Summary

Before

Bildschirmaufzeichnung.vom.22.04.2024.13.14.03.webm

After

refresh-files-view.webm

@Fenn-CS Fenn-CS added this to the Nextcloud 29.0.3 milestone Jun 21, 2024
@Fenn-CS Fenn-CS self-assigned this Jun 21, 2024
@blizzz blizzz mentioned this pull request Jun 21, 2024
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 21, 2024

/backport to stable29

@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 21, 2024

/backport to stable28

@Fenn-CS Fenn-CS force-pushed the fix/44961/shared-state-file-list branch 4 times, most recently from 57ab1b4 to a10c018 Compare June 21, 2024 20:04
apps/files_sharing/src/views/SharingDetailsTab.vue Outdated Show resolved Hide resolved
apps/files_sharing/src/views/SharingDetailsTab.vue Outdated Show resolved Hide resolved
@Fenn-CS Fenn-CS force-pushed the fix/44961/shared-state-file-list branch from a10c018 to fc68cd6 Compare June 24, 2024 09:28
@max-nextcloud
Copy link
Contributor

After adjusting the logger import sharing with alice works nicely.
However if I just create a link share the left side is still not updated.

Bildschirmaufzeichnung.vom.25.06.2024.06.06.20.webm

Would be nice to tackle that as well.

@Fenn-CS Fenn-CS force-pushed the fix/44961/shared-state-file-list branch from fc68cd6 to 5927e3c Compare June 25, 2024 06:42
@szaimen
Copy link
Contributor

szaimen commented Jun 25, 2024

This also resolves #40263, I suppose?

@Fenn-CS Fenn-CS force-pushed the fix/44961/shared-state-file-list branch from 5927e3c to 02199b2 Compare June 25, 2024 11:26
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried again... works like a charm now 🪄

Thanks! ❤️

Resolves : #44961

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@Fenn-CS Fenn-CS force-pushed the fix/44961/shared-state-file-list branch from 02199b2 to f7527c3 Compare June 25, 2024 17:16
@Fenn-CS
Copy link
Contributor Author

Fenn-CS commented Jun 25, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Fenn-CS Fenn-CS merged commit f018222 into master Jun 25, 2024
110 checks passed
@Fenn-CS Fenn-CS deleted the fix/44961/shared-state-file-list branch June 25, 2024 19:51
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🏗️ In progress
6 participants