-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_versions): Use NcDateTime
for proper translated version dates
#45900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/backport to stable29 |
/backport to stable28 |
AndyScherzinger
approved these changes
Jun 16, 2024
artonge
approved these changes
Jun 17, 2024
…operly Also do not use filters, filters are deprecated and will make migration to Vue 3 harder. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…low viewing on small screens Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
AndyScherzinger
force-pushed
the
fix/files-versions-date
branch
from
June 17, 2024 07:22
035d0bc
to
9c67df1
Compare
/compile / |
AndyScherzinger
force-pushed
the
fix/files-versions-date
branch
from
June 17, 2024 07:29
9c67df1
to
78871a8
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-versions-date
branch
from
June 17, 2024 07:29
78871a8
to
879120d
Compare
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/45900/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 9f22538c 99262130 879120dd
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/45900/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Basically this contains 3 notable changes:
NcDateTime
instead of moment to fix version dates not being translated correctlyScreenshots
Checklist