fix(dist): Make sure changed icons are compiled #45712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nickvergessen
commented
Jun 7, 2024
nickvergessen
commented
- Regression from Updated images for Material icons and added SPDX info #45706 which only changed icons
- it did not recompile the icons.css
- but since no matching file was changed, the node.yml job didn't run there
- Since then all PRs that do change a checked file fail with red CI without having changed the file.
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
requested review from
AndyScherzinger,
susnux,
skjnldsv and
provokateurin
blizzz
approved these changes
Jun 7, 2024
provokateurin
approved these changes
Jun 7, 2024
susnux
approved these changes
Jun 7, 2024
|
Missing: Noticed on this PR, which was merged without compiled styles #46270 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.