Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(caldav): stricter default calendar checks #45667

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(caldav): stricter default calendar checks #45667

merged 1 commit into from
Jul 23, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jun 4, 2024 •
edited
Loading

Summary

Reject calendars that

  • are subscriptions
  • are not writable
  • are shared by a user
  • are deleted
  • don't support VEVENTs

Checklist

@st3iny st3iny added 2. developing Work in progress feature: caldav Related to CalDAV internals labels Jun 4, 2024
@st3iny st3iny self-assigned this Jun 4, 2024
@st3iny
Copy link
Member Author

st3iny commented Jun 5, 2024

/backport to stable29

@st3iny st3iny force-pushed the fix/caldav/strict-default-calendar-checks branch from 9db8a35 to 3d5e847 Compare June 5, 2024 07:11
@st3iny st3iny added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 5, 2024
@st3iny st3iny added this to the Nextcloud 30 milestone Jun 5, 2024
@st3iny st3iny added the bug label Jun 5, 2024
@st3iny st3iny marked this pull request as ready for review June 5, 2024 07:13
@st3iny st3iny force-pushed the fix/caldav/strict-default-calendar-checks branch from 3d5e847 to a0d8728 Compare June 5, 2024 07:27
@st3iny
Copy link
Member Author

st3iny commented Jun 5, 2024

I just realized that the fallback propFind method is also broken, when a task list is on top. So we have to do the same checks in our schedule plugin, too.

I'll push another commit and some tests.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 5, 2024
View reviewed changes
apps/dav/lib/Connector/Sabre/ServerFactory.php Dismissed Show dismissed Hide dismissed
apps/dav/lib/Server.php Dismissed Show dismissed Hide dismissed
apps/dav/lib/Server.php Dismissed Show dismissed Hide dismissed
@st3iny
fix(caldav): stricter default calendar checks
cbea787 
Reject calendars that
- are subscriptions
- are not writable
- are shared with a user
- are deleted
- don't support VEVENTs

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny force-pushed the fix/caldav/strict-default-calendar-checks branch from a635a94 to cbea787 Compare July 22, 2024 13:24
miaulalala
miaulalala approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@st3iny st3iny merged commit e54d39b into master Jul 23, 2024
168 checks passed
@st3iny st3iny deleted the fix/caldav/strict-default-calendar-checks branch July 23, 2024 06:40
@backportbot backportbot bot mentioned this pull request Jul 23, 2024
Merged
2 tasks
@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld left review comments

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@miaulalala miaulalala miaulalala approved these changes

Assignees

@st3iny st3iny

Labels
3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals
Projects
None yet
Milestone
Nextcloud 30
4 participants
@st3iny @ChristophWurst @tcitworld @miaulalala