Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ObjectStore): Fix regression when hostname is empty #45649

Merged
merged 1 commit into from
Jun 12, 2024
Merged

fix(ObjectStore): Fix regression when hostname is empty #45649

merged 1 commit into from
Jun 12, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 3, 2024 •
edited
Loading

Summary

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when hostname is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

TODO

  • ...

Checklist

@joshtrichards joshtrichards added this to the Nextcloud 30 milestone Jun 3, 2024
@joshtrichards
Copy link
Member Author

/backport to stable29

@joshtrichards
Copy link
Member Author

/backport to stable28

@joshtrichards
Copy link
Member Author

/backport to stable27

@joshtrichards joshtrichards mentioned this pull request Jun 3, 2024
Closed
@joshtrichards joshtrichards force-pushed the jtr/fix-oo-s3-no-hostname branch 2 times, most recently from 5defd2a to cb7bbf6 Compare June 3, 2024 21:48
@joshtrichards
fix(ObjectStore): handle empty S3 hostname
6388614 
Fixes #45637

The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated).

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 12, 2024
@susnux susnux merged commit b3e4270 into master Jun 12, 2024
164 checks passed
@susnux susnux deleted the jtr/fix-oo-s3-no-hostname branch June 12, 2024 20:56
@backportbot backportbot bot mentioned this pull request Jun 12, 2024
Merged
This was referenced Jun 12, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@susnux susnux susnux approved these changes

@artonge artonge artonge approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: object storage feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

S3 causes an issue when no hostname is set.
4 participants
@joshtrichards @susnux @kesselb @artonge