fix(files): Make sure files are opened when using open-in-files action(s) or at lease are scrolled into view
#45611
Conversation
|
/backport to stable29 |
|
/backport to stable28 |
But should it be open, is it really a bug? After clicking, it goes to the file, selects it, scrolls to it and opens it in the sidebar. Should the file (especially if it is a heavy file like a document) be immediately open in viewer? |
yes afaik |
Yes that is the expected "open" behavior, you can open the details also in the "shares"-view. But the actions says "download xyz" or "open xyz" (depending on the type). |
| @@ -238,7 +238,7 @@ export default defineComponent({ | |||
| }, | |||
|
|
|||
| mountType() { | |||
| return this.source._attributes['mount-type'] | |||
| return this.source.attributes['mount-type'] | |||
|
/compile |
artonge
added
4. to release
|
Rebased to resolve conflicts. |
Need one more 🙈 |
* We filter the array in `enabledSubmenuActions` so we can be sure the action does have a parent * Node attributes must be accessed using the `attributes` getter not the private `_attributes` property * Cast action ref to correct component interface to make TypeScript happy Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Ensure the correct file is scrolled if the content changes, this also sets a minimal height to the virtual scrolling area so that the `scrollTop` can be set. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
done |
Summary
This fixes following isses:
open-in-filesactions theopenfilequery should be set to trigger openingopenfilescrollTopcan not be set as the height is not fully setup yet.Before
See that the file is not scrolled into view
Screencast_20240531_161643.webm
After
See that the file entry is now visible
Screencast_20240531_161912.webm
Checklist