-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement public OCP api to update resources and rooms #45532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
added
2. developing
Work in progress
feature: caldav
Related to CalDAV internals
labels
May 27, 2024
apps/dav/lib/BackgroundJob/UpdateCalendarResourcesRoomsBackgroundJob.php
Fixed
Show fixed
Hide fixed
st3iny
changed the title
feat: update resources and rooms from \OCP\Calendar\IManager
feat: implement public OCP api to update resources and rooms
May 27, 2024
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
st3iny
force-pushed
the
feat/publish-resources-room-update
branch
from
May 27, 2024 16:45
9f7e41a
to
69e0158
Compare
st3iny
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
May 28, 2024
miaulalala
approved these changes
May 28, 2024
ChristophWurst
added
the
pending documentation
This pull request needs an associated documentation update
label
Jun 25, 2024
ChristophWurst
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
AndyScherzinger
approved these changes
Jun 25, 2024
* | ||
* @since 30.0.0 | ||
*/ | ||
public function update(): void; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
enhancement
feature: caldav
Related to CalDAV internals
pending documentation
This pull request needs an associated documentation update
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref nextcloud/calendar_resource_management#126
Allow to trigger a synchronous update of rooms and resources via a public OCP api instead of waiting for the background job.
The job itself is untouched. I only moved the contained logic to a separate class inside
lib/private
.Checklist