fix: use different file name for generated dark avatars #45514
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I wondered, while debugging an issue, about many write requests for my generated user avatar.
Likely the condition
$darkTheme && !$generated
should be$darkTheme && $generated
to match the implementation inUserAvatar.getFile
.If you want to reproduce, make sure to NOT have a default generated avatar.
Super edgy, no backports needed.
server/lib/private/Avatar/UserAvatar.php
Lines 172 to 184 in ae4a6e8
Screencast.from.2024-05-26.17-13-51.webm
TODO
Checklist