Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): Prevent data loss by temporarily disabling db:convert-type #45400

Merged
merged 2 commits into from
May 22, 2024

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented May 18, 2024

WARNING: Needed until #45257 is addressed to prevent data loss

Summary

Currently the bug described in #45257 (and related #45097) has a serious side effect/interaction with the occ db:convert-type command which results in dropping the source database.

Based on preliminary analysis, this is likely a bug arising from changes made in #41998 that were released as part of 29.0.0.

If we're unable to address #45257 prior to the release of 29.0.1 in a few days, then I propose we disable occ db:convert-type temporarily (hopefully just until the next maintenance release) rather than risk people wiping out their database. That is the purpose of this PR.

This is a backup PR which I propose merging in master and backporting to 29.0.1 prior to it being published if necessary.

If it turns out to be unnecessary, all the better.

TODO

Checklist

Needed until #45257 is addressed to prevent data loss

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
Copy link
Member Author

/backport to stable29

Signed-off-by: Josh <josh.t.richards@gmail.com>
@skjnldsv skjnldsv mentioned this pull request May 22, 2024
24 tasks
@AndyScherzinger AndyScherzinger merged commit 2f8176f into master May 22, 2024
155 checks passed
@AndyScherzinger AndyScherzinger deleted the temp-db-replica-loss-prevention branch May 22, 2024 17:00
@szaimen
Copy link
Contributor

szaimen commented May 31, 2024

Hi, can this be reverted now that #45013 is merged?

This comment was marked as outdated.

@AndyScherzinger
Copy link
Member

@ChristophWurst
Copy link
Member

lib/private/DB/ConnectionFactory.php hasn't been touched so I assume it's still happening. @szaimen can you test?

@CorneliousJD
Copy link

Checking in to see if there's an update to this at all -- I have a need to convert from a problematic mariadb install that keeps continually corrupting my oc_filescache table and move to PostgreSQL instead.

Just about every week I have data corruption on my mariadb -- looking to convert ASAP and was sad to see the command is currently disabled.

Is there any specific override or anything that I could try knowing that I need backups first?

@blizzz blizzz mentioned this pull request Jul 24, 2024
@techsolo12
Copy link

Hello together,

any news on this PR? We still can't migrate databases to other types. Please add a addional override like "--force" or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants