-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move hint about firewall issues to common helper string #45254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise. Just a couple typos and suggestions for added clarity while we're here. :)
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de> Co-authored-by: Josh <josh.t.richards@gmail.com> Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
I was just searching for the responsible code part, because it was in some bug reports on the forum (https://help.nextcloud.com/t/ipv6-only-cant-connect-to-itself/196260). Does it make sense to make a backport to current versions? Or is there a good reason not to do it? |
Summary
Currently the information why the setup check might have failed is duplicated, so move the information to the common helper string instead of only the mjs check.
Checklist