-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove reminder action from trash #45227
Conversation
Pull request was converted to draft
027ee2d
to
afb72df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove reminders from the DB when a file gets deleted?
Works this way already actually https://github.com/nextcloud/server/blob/master/apps/files_reminders/lib/Listener/NodeDeletedListener.php |
@@ -32,7 +35,10 @@ export const action = new FileAction({ | |||
title: () => t('files_reminders', 'Set reminder at custom date & time'), | |||
iconSvgInline: () => CalendarClockSvg, | |||
|
|||
enabled: () => true, | |||
enabled: (_nodes: Node[], view: View) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe future APIs should just have context objects to allow to only destructure the needed property
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
afb72df
to
8138516
Compare
Summary
Checklist