Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce available languages per config value "reduce_to_languages" #44876

Conversation

printminion-co
Copy link
Contributor

@printminion-co printminion-co commented Apr 17, 2024

Example: restrict to en, de, es, fr, it languages

./occ config:system:set reduce_to_languages 0  --value  en 
./occ config:system:set reduce_to_languages 1  --value  de 
./occ config:system:set reduce_to_languages 2  --value  es 
./occ config:system:set reduce_to_languages 3  --value  fr 
./occ config:system:set reduce_to_languages 4  --value  it
  • Resolves: #

Summary

TODO

  • ...

Checklist

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I guess having users still with the other selected languages is fine? Or should we handle that with a repair step/option

@nickvergessen nickvergessen requested review from a team, ArtificialOwl, icewind1991 and yemkareems and removed request for a team April 17, 2024 14:33
@nickvergessen nickvergessen added this to the Nextcloud 30 milestone Apr 17, 2024
@nickvergessen
Copy link
Member

Can you rebase so we see if CI passes now?

@printminion-co printminion-co force-pushed the feat/reduce_available_languages_set branch from 0dd1b94 to 4b923df Compare June 27, 2024 10:02
@printminion-co printminion-co force-pushed the feat/reduce_available_languages_set branch 3 times, most recently from 9679f13 to ae4a829 Compare June 27, 2024 13:09
Example: restrict to en, de, es, fr, it' languages

./occ config:system:set reduce_to_languages 0  --value  en
./occ config:system:set reduce_to_languages 1  --value  de
./occ config:system:set reduce_to_languages 2  --value  es
./occ config:system:set reduce_to_languages 3  --value  fr
./occ config:system:set reduce_to_languages 4  --value  it

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
auto-merge was automatically disabled July 1, 2024 07:34

Head branch was pushed to by a user without write access

@printminion-co printminion-co force-pushed the feat/reduce_available_languages_set branch from ae4a829 to aceb4d7 Compare July 1, 2024 07:34
@nickvergessen nickvergessen merged commit 7525edd into nextcloud:master Jul 1, 2024
163 of 165 checks passed
Copy link

welcome bot commented Jul 1, 2024

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@blizzz blizzz mentioned this pull request Jul 24, 2024
@printminion-co
Copy link
Contributor Author

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants