Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add deprecation to OC.dialogs.fileexists #44756

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 9, 2024

Summary

We already ship this since 28, but forgot to deprecate the legacy method.
Lets deprecate it officially to be able to get rid of it as soon as possible.

Also ref #44755

Checklist

@susnux susnux added bug 3. to review Waiting for reviews labels Apr 9, 2024
@susnux susnux added this to the Nextcloud 30 milestone Apr 9, 2024
@susnux
Copy link
Contributor Author

susnux commented Apr 9, 2024

/backport to stable29

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@Pytal Pytal merged commit 9a319ba into master Apr 9, 2024
104 checks passed
@Pytal Pytal deleted the fix/deprecate-fileexits branch April 9, 2024 18:45
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants