Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Do not show files from hidden folders in "Recent"-view if hidden files are disabled by user #44661

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(files): Do not show files from hidden folders in "Recent"-view if hidden files are disabled by user #44661

merged 2 commits into from
Apr 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 4, 2024 •
edited
Loading

Summary

Have a hidden folder .foo and create a file inside (.foo/bar) then the file bar is shown in recent even if it is basically hidden.

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 4, 2024
@susnux susnux requested a review from a team April 4, 2024 17:58
@susnux susnux requested a review from skjnldsv as a code owner April 4, 2024 17:58
@susnux susnux requested review from szaimen and emoral435 and removed request for a team April 4, 2024 17:58
@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Apr 4, 2024

/backport to stable29

This was referenced Apr 4, 2024
Closed
Closed
@susnux susnux force-pushed the fix/hide-hidden-recent-files-v2 branch from 6b8bf50 to 2023b6d Compare April 4, 2024 20:22
@susnux susnux requested a review from skjnldsv April 4, 2024 20:22
@susnux susnux force-pushed the fix/hide-hidden-recent-files-v2 branch from 2023b6d to bdd24da Compare April 5, 2024 13:45
@susnux susnux requested review from skjnldsv and Pytal April 5, 2024 13:48
emoral435
emoral435 reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be asking questions that are easily resolved, but everything LGTM!

apps/files/src/views/FilesList.vue Show resolved Hide resolved
apps/files/src/services/Recent.ts Outdated Show resolved Hide resolved
@susnux susnux requested a review from emoral435 April 9, 2024 14:04
emoral435
emoral435 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good :)

@susnux susnux force-pushed the fix/hide-hidden-recent-files-v2 branch from bdd24da to 8be2c2b Compare April 16, 2024 12:33
@susnux susnux force-pushed the fix/hide-hidden-recent-files-v2 branch from 8be2c2b to 93e2363 Compare April 16, 2024 18:26
@susnux
fix(files): Do not show files from hidden folders in "Recent"-view if…
e545eee 
… hidden files are disabled by user

Needed to adjust the store creation to be able to inject pinia before the vue app is initialized.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
acbb699 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the fix/hide-hidden-recent-files-v2 branch from 93e2363 to acbb699 Compare April 16, 2024 21:52
@susnux susnux enabled auto-merge April 16, 2024 21:52
@susnux susnux merged commit a2999d8 into master Apr 16, 2024
104 checks passed
@susnux susnux deleted the fix/hide-hidden-recent-files-v2 branch April 16, 2024 22:11
This was referenced Apr 16, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@emoral435 emoral435 emoral435 approved these changes

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files feedback-requested
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.
4 participants
@susnux @skjnldsv @Pytal @emoral435