Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show upload menu in folders' emptycontent #44272

Merged
merged 2 commits into from
May 29, 2024
Merged

Show upload menu in folders' emptycontent #44272

merged 2 commits into from
May 29, 2024

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini added the 3. to review Waiting for reviews label Mar 18, 2024
@marcoambrosini marcoambrosini self-assigned this Mar 18, 2024
@marcoambrosini marcoambrosini requested review from szaimen and a team March 18, 2024 11:59
@marcoambrosini marcoambrosini force-pushed the feature/40205/show-add-menu-in-emptycontent branch from 17ac04c to 45f02fb Compare March 18, 2024 12:01
szaimen
szaimen approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and seems to work. Really nice UX improvement! :)

@szaimen szaimen added this to the Nextcloud 29 milestone Mar 18, 2024
susnux
susnux approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice UX!

@Altahrim Altahrim mentioned this pull request Mar 18, 2024
Merged
@susnux
Copy link
Contributor

susnux commented Mar 19, 2024

@marcoambrosini can you please adjust your commit message to comply with conventional commits? :)

skjnldsv
skjnldsv requested changes Mar 19, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message does not mean the folder truly exists

@marcoambrosini
Copy link
Member Author

So what would be the best way to check that the folder exists @skjnldsv

@skjnldsv
Copy link
Member

There are many factors you need to check to show an UploadPicker

  1. Does the directory exists (see currentFolder)
  2. Does the user have create permissions on that folder ?

Additional data:

What you are editing is shared between ALL views, the deleted files, the tags, the shares, favorites.... etc. We need to keep the Go Back feature alongside the upload picker.

This was referenced Mar 20, 2024
Merged
Merged
@jancborchardt
Copy link
Member

@marcoambrosini do you still want to have this in beta 6? If so, the last call for that is happening now, otherwise we have to move it to 30.

@skjnldsv
Copy link
Member

@jancborchardt we're far into features freeze (3 weeks) and Rc1 is this week

@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
This was referenced Apr 4, 2024
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 29, Nextcloud 30 Apr 8, 2024
@susnux susnux force-pushed the feature/40205/show-add-menu-in-emptycontent branch 2 times, most recently from a47732f to 6ba706a Compare May 16, 2024 21:40
@susnux susnux requested a review from skjnldsv May 16, 2024 21:40
@susnux
Copy link
Contributor

susnux commented May 16, 2024

@skjnldsv @marcoambrosini I pushed a commit to bring back the back button if upload is not possible.

@susnux susnux force-pushed the feature/40205/show-add-menu-in-emptycontent branch from 6ba706a to bd4a107 Compare May 16, 2024 21:43
@susnux
Copy link
Contributor

susnux commented May 17, 2024

/compile

skjnldsv
skjnldsv approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@marcoambrosini
Copy link
Member Author

I can't figure out what's wrong with the failures

marcoambrosini and others added 2 commits May 29, 2024 14:44
@marcoambrosini @susnux
feat(files): Show upload menu in folders' emptycontent
1526a6f 
Signed-off-by: Marco <marcoambrosini@icloud.com>
@susnux
fix(files): Keep 'back'-button for not found directories or if user c…
1463592 
…an not upload

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux force-pushed the feature/40205/show-add-menu-in-emptycontent branch from 65b1156 to 1463592 Compare May 29, 2024 12:47
@skjnldsv skjnldsv merged commit 9277def into master May 29, 2024
104 checks passed
@skjnldsv skjnldsv deleted the feature/40205/show-add-menu-in-emptycontent branch May 29, 2024 15:11
@skjnldsv
Copy link
Member

Thanks @susnux !

@marcoambrosini
Copy link
Member Author

What was it @susnux ?

@susnux
Copy link
Contributor

susnux commented May 29, 2024

What was it @susnux ?

Just flaky and needed to be restarted

@blizzz blizzz mentioned this pull request Jul 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@marcoambrosini marcoambrosini

Labels
3. to review Waiting for reviews enhancement
Projects
🖍 Design team
Archived in project
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Should the empty folder button ask to upload something instead of going back?
7 participants
@marcoambrosini @susnux @skjnldsv @jancborchardt @Pytal @szaimen @blizzz