fix: Remove calls to deprecated OC_JSON::encode #44015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/remove-oc-json-encode-usages
branch
from
a84d634
to
518eab4
Compare
susnux
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
icewind1991
approved these changes
Mar 6, 2024
to_string was useless because L10N string is json serializable now and serialize to string correctly. Removed all external calls to OC_JSON::encode to ease removing the rest of it later. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/remove-oc-json-encode-usages
branch
from
518eab4
to
ead574b
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to_string was useless because L10N string is json serializable now and serialize to string correctly. Removed all external calls to OC_JSON::encode to ease removing the rest of it later.
Checklist