feat: add pronouns to account profile #44013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
skjnldsv
force-pushed
the
fieat/profile-pronounces
branch
from
bd95aa8 to
3d77190
Compare
susnux
reviewed
Mar 6, 2024
skjnldsv
added
2. developing
Pytal
reviewed
Mar 7, 2024
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
jancborchardt
approved these changes
Aug 8, 2024
This comment has been minimized.
This comment has been minimized.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
It's just not the place to have a discussion on if a feature is controversial or not. |
It's optional to put in pronouns, soo … |
skjnldsv
force-pushed
the
fieat/profile-pronounces
branch
from
d934fba to
64549d0
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fieat/profile-pronounces
branch
3 times, most recently
from
8a4e7c3 to
2e04ce6
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fieat/profile-pronounces
branch
from
2e04ce6 to
b24e02e
Compare
|
Let's go!! 🚀 |
skjnldsv
requested review from
artonge,
a team,
susnux and
Pytal
and removed request for
a team
skjnldsv
requested review from
a team
and removed request for
provokateurin
skjnldsv
added
3. to review
Pytal
approved these changes
Sep 17, 2024
Comment on lines
+441
to
+442
| // Overlap avatar to top header | ||
| margin-top: -110px !important; |
There was a problem hiding this comment.
Suggested change
| // Overlap avatar to top header | |
| margin-top: -110px !important; | |
| // Overlap avatar to top header | |
| margin-top: -110px !important; |
I'll double check with Arthur tomorrow :) |
|
@skjnldsv This broke the tests but the CI was wrongly green. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #40017