Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable9] Add Same Site Cookie protection #44

Merged
merged 1 commit into from
Jun 11, 2016

Conversation

LukasReschke
Copy link
Member

No description provided.

@LukasReschke LukasReschke added the 2. developing Work in progress label Jun 10, 2016
@LukasReschke LukasReschke self-assigned this Jun 10, 2016
@LukasReschke LukasReschke added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 10, 2016
@LukasReschke
Copy link
Member Author

@MorrisJobke @blizzz @schiessle Could you test whether it still works for you with your browser and locally as well? THX a lot! :)

@LukasReschke LukasReschke merged commit bd8d50d into stable9 Jun 11, 2016
@LukasReschke LukasReschke deleted the stable9-add-same-site-cookies branch June 11, 2016 08:31
@blizzz
Copy link
Member

blizzz commented Jun 11, 2016

@LukasReschke login works, up- and downloading files, too. Anything more specific to test?

@LukasReschke
Copy link
Member Author

@LukasReschke login works, up- and downloading files, too. Anything more specific to test?

A quick test on the Android app and locally syncing would be appreciated as well. Especially in the case of: Stable9 without this patch then apply stable9 with this patch.

It should actually just show a failed connection quickly (or not even that) and then continue syncing for the future without any problems. So syncing should basically work 😄

@blizzz
Copy link
Member

blizzz commented Jun 13, 2016

  • configured with the Android app and sync client
  • edited a file locally
  • was synced up to server and down to android app

→ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants