-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
settings: Refactor appstore and user management code #43769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
enhancement
3. to review
Waiting for reviews
feature: users and groups
feature: apps management
labels
Feb 22, 2024
Pytal
reviewed
Feb 22, 2024
susnux
force-pushed
the
enh/refactor-appstore
branch
2 times, most recently
from
February 22, 2024 17:17
e24f968
to
cbc0546
Compare
Pytal
reviewed
Feb 22, 2024
susnux
force-pushed
the
enh/refactor-appstore
branch
from
February 22, 2024 18:08
cbc0546
to
87bc634
Compare
Pytal
approved these changes
Feb 22, 2024
susnux
force-pushed
the
enh/refactor-appstore
branch
from
February 22, 2024 22:07
87bc634
to
6781450
Compare
skjnldsv
approved these changes
Feb 23, 2024
…property Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
… initial state Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
skjnldsv
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Feb 23, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enh/refactor-appstore
branch
from
February 23, 2024 21:00
6781450
to
43a9782
Compare
nfebe
approved these changes
Feb 23, 2024
Possible performance regression detected Show Output
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
enhancement
feature: apps management
feature: users and groups
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some refactoring of code for user management and the appstore just to get the changes for my app discover PR small.
This refactors the code to use initial state instead of the custom solution.
Checklist