-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Expose the confirm password endpoint #43668
feat(core): Expose the confirm password endpoint #43668
Conversation
Signed-off-by: provokateurin <kate@provokateurin.de>
Ah of course this stills needs the frontend changes to work with the new endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, but I would prefer to add/duplicate it into https://github.com/nextcloud/server/blob/master/core/Controller/AppPasswordController.php to have it available as proper OCS API
Currently this is non breaking and nothing needs changes? Or am I missing something? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only change is adding NoCSRFRequired
- right?
You're both right, I thought I had converted it to OCS which is not true 😅 |
#[UseSession] | ||
public function confirmUserPassword(string $password): DataResponse { | ||
$loginName = $this->userSession->getLoginName(); | ||
$loginResult = $this->userManager->checkPassword($loginName, $password); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
e4de634
to
8f91df8
Compare
Signed-off-by: provokateurin <kate@provokateurin.de>
8f91df8
to
6243a94
Compare
Second try of #43000
Summary
This allows non-web clients to confirm the password in order to use endpoints that require it.
Checklist