Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old theming migration steps as they are only needed once #43570

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

juliushaertl
Copy link
Member

@juliushaertl juliushaertl commented Feb 14, 2024

Those migration steps were introduced with Nextcloud 26 to migrate config values but are no longer required on subsequent major upgrades. On instances with a large user base the MigrateUserConfig can take a large amount of time to iterate over users that already have been migrated (50 min on a 3 million user instance I've seen)

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliushaertl juliushaertl requested review from a team, ArtificialOwl and blizzz and removed request for a team February 14, 2024 10:15
@juliushaertl juliushaertl requested a review from a team February 14, 2024 10:30
@skjnldsv skjnldsv merged commit 0fb3cfd into master Feb 14, 2024
156 checks passed
@skjnldsv skjnldsv deleted the chore/remove-old-migrations branch February 14, 2024 16:54
@skjnldsv skjnldsv added this to the Nextcloud 29 milestone Feb 14, 2024
@juliushaertl
Copy link
Member Author

/backport to stable28

@juliushaertl
Copy link
Member Author

/backport to stable27

Copy link

backportbot bot commented Feb 14, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/43570/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick acda6b84

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43570/stable27

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants