Fix AdBlock blocking share icon, ref #866 #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
3. to review
|
@jancborchardt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @VicDeo and @blizzz to be potential reviewers. |
This was referenced Apr 12, 2017
|
Please also review the pull requests to Calendar nextcloud/calendar#417 and Contacts nextcloud/contacts#188 :) |
MorrisJobke
approved these changes
Apr 12, 2017
MariusBluem
approved these changes
Apr 13, 2017
| @@ -326,14 +326,12 @@ img, object, video, button, textarea, input, select { | |||
| background-image: url('../img/actions/settings-white.svg?v=1'); | |||
| } | |||
|
|
|||
| /* always use icon-shared, AdBlock blocks icon-share */ | |||
| .icon-shared, | |||
There was a problem hiding this comment.
This now uses a different image 👎 please fix
There was a problem hiding this comment.
The images share.svg and shared.svg are and have always been exactly the same. What’s the issue exactly?
This was referenced Apr 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally takes care of the share icon being blocked by AdBlock (or other adblocking plugins). As the user bases of Adblock and Nextcloud probably have some reasonable overlap, we should fix this.
This is simply achieved by renaming the class from icon-share to icon-shared, which doesn’t seem to be blocked.
Ref #866, please review @kumzugloom @Pommesumdreher @MariusBluem @Bullnados @GetBoz @schiessle
Before: share icon is missing, and with that you don’t really know where to click / how to share:
After: it’s displayed, as intended – same as when you don’t have Adblock:
Will also open pull requests to open this in other apps using the icons, like Calendar and Contacts.
Also, I would say this is a bugfix to backport – any objection @rullzer? ;)