movie preview bug fix, in some case stream reading functions may block indefinitely #43226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpsn123
changed the title
joshtrichards
changed the title
joshtrichards
changed the title
Merged
Merged
5 tasks
blizzz
reviewed
May 20, 2025
There was a problem hiding this comment.
From the documentation:
In non-blocking mode an fgets() call will always return right away while in blocking mode it will wait for data to become available on the stream.
Could be more exhaustive. Is it possible that we only receive incomplete data with this setting?
jpsn123
requested review from
Altahrim,
artonge and
leftybournes
and removed request for
a team
|
@jpsn123 thanks for the adaptions! Would you mind rebasing one more time? |
|
@blizzz thanks for remind, i amend it, merge to one commit |
blizzz
approved these changes
Jun 17, 2025
blizzz
added
bug
3. to review
jpsn123
force-pushed
the
master
branch
2 times, most recently
from
f6bcc28 to
8b802d7
Compare
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
…ctions may block indefinitel
|
@jpsn123 sorry for the delay here. Can you sign off your commit? git rebase HEAD~1 --signoff
git push --force-with-lease origin masterThen we should be good :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For some reason, I need to run nextcloud as root, and in this case ffmpeg will block the process when it generates preview.
refencese:
https://www.php.net/manual/en/function.proc-open.php#97012
https://www.php.net/manual/en/function.stream-get-contents.php#106905