-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(appconfig): Automatically store "sensitive" appconfigs encrypted in the database #43114
Merged
nickvergessen
merged 2 commits into
master
from
bugfix/noid/automatically-encrypt-sensitive-values
Mar 7, 2024
Merged
feat(appconfig): Automatically store "sensitive" appconfigs encrypted in the database #43114
nickvergessen
merged 2 commits into
master
from
bugfix/noid/automatically-encrypt-sensitive-values
Mar 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
changed the base branch from
master
to
enh/noid/improve-index-on-appconfig
January 25, 2024 13:35
ArtificialOwl
approved these changes
Jan 25, 2024
Base automatically changed from
enh/noid/improve-index-on-appconfig
to
master
January 26, 2024 10:53
nickvergessen
force-pushed
the
bugfix/noid/automatically-encrypt-sensitive-values
branch
from
January 26, 2024 21:05
2ef454d
to
6d20fd0
Compare
… in the database Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/automatically-encrypt-sensitive-values
branch
from
March 6, 2024 21:27
6d20fd0
to
24607a3
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/automatically-encrypt-sensitive-values
branch
from
March 6, 2024 21:59
e77d9e4
to
3a67080
Compare
Merged
ArtificialOwl
approved these changes
Mar 6, 2024
AndyScherzinger
approved these changes
Mar 6, 2024
nickvergessen
deleted the
bugfix/noid/automatically-encrypt-sensitive-values
branch
March 7, 2024 08:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Quite some app configs contain sensitive information that we could prevent to leak, when a backup of the DB is leaked, to reduce the risk of follow up leaks/hacks.
The state of the art is to use
ICrypto::encrypt()
andICrypto::decrypt()
for that. While looking into it for some of the talk configs which are arrays, I thought it's a shame that we would loose all the typing as we have to json_encode the config making it strings, in order to be able to encrypt them.So why not just encrypt all sensitive configs all the time automatically?
TODO
getAllValues
andgetDetails
Checklist