update webauthn section to feature components #42698
Merged
+24
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
force-pushed
the
enh/42595/webauthn-ncnotecard
branch
from
f2e7af7 to
5675551
Compare
szaimen
changed the title
szaimen
added
design
ShGKme
reviewed
Jan 11, 2024
| @@ -25,9 +25,9 @@ | |||
| </div> | |||
| <div v-else> | |||
| <div v-if="step === RegistrationSteps.READY"> | |||
| <button @click="start"> | |||
| <NcButton @click="start" type="primary"> | |||
There was a problem hiding this comment.
Doesn't primay make too much attention here?
There was a problem hiding this comment.
I would say primary is fine here. We also use it in the other sections
There was a problem hiding this comment.
Probably would also go with tertiary but not I am not a designer.
ShGKme
approved these changes
Jan 11, 2024
susnux
approved these changes
Jan 11, 2024
Signed-off-by: Simon L <szaimen@e.mail.de>
szaimen
force-pushed
the
enh/42595/webauthn-ncnotecard
branch
from
5675551 to
541f25a
Compare
|
/compile |
|
/backport 541f25a to stable28 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
emoral435
approved these changes
Jan 11, 2024
|
CI failure unrelated IIRC |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #42595
For my own testing