-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occ background-job:delete #42670
occ background-job:delete #42670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is potentially very dangerous and at the same time some apps might regenerate their jobs.
So far I never had the case where an admin would have needed to delete a job? Can you give an example?
use Symfony\Component\Console\Output\OutputInterface; | ||
use Symfony\Component\Console\Question\ConfirmationQuestion; | ||
|
||
class DeleteCommand extends Base { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class DeleteCommand extends Base { | |
class DeleteJob extends Base { |
?
The only one I have in mind right now is this issue with a background job that could not resolve itself: It is a unique job that remove itself when its purpose is over. |
56c72e3
to
57ddf34
Compare
57ddf34
to
ef2c76d
Compare
Please just name the file Delete.php and the class Delete if the command is :delete. ListCommmand is called ListCommand because list is a reserved keyword, delete is not. |
f91d673
to
7001e41
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
7001e41
to
bd3df75
Compare
Could "hide" being |
/backport to stable28 |
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
allow an admin to remove a background job entry from the database