Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix(cypress): Adjust user columns tests #41945

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 30, 2023

Summary

When selecting the modal we should make sure to select the user settings modal and not any other (in this case global search).

Checklist

…cting a modal

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added bug 3. to review Waiting for reviews tests Related to tests labels Nov 30, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 30, 2023
@susnux
Copy link
Contributor Author

susnux commented Nov 30, 2023

/backport to master

@blizzz blizzz mentioned this pull request Nov 30, 2023
3 tasks
@blizzz blizzz added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 30, 2023
@AndyScherzinger AndyScherzinger merged commit ba53734 into stable28 Nov 30, 2023
41 of 42 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/stable28-cypress-global-search-modal branch November 30, 2023 20:55
@nickvergessen
Copy link
Member

backport to master did not work, please do manually

@AndyScherzinger
Copy link
Member

manual forward-port is #41958

@blizzz blizzz mentioned this pull request Dec 1, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug tests Related to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants