Migrate openResult method to SearchResult component #41785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
requested review from
ChristophWurst,
SystemKeeper,
susnux and
artonge
Fenn-CS
force-pushed
the
fix-open-search-result
branch
from
86cf466
to
3f4a7a2
Compare
22 tasks
ChristophWurst
previously requested changes
Nov 28, 2023
@ChristophWurst using the |
|
Then the component needs a new prop to influence this behavior |
artonge
approved these changes
Nov 28, 2023
|
@ChristophWurst that makes sense, I have created these issue for that here : nextcloud-libraries/nextcloud-vue#4880 and here #41800 Because this breaks search entirely, so this PR should restore the old initial before of using JavaScript to trigger the routing. |
Fenn-CS
force-pushed
the
fix-open-search-result
branch
from
3f4a7a2
to
0710327
Compare
AndyScherzinger
approved these changes
Nov 29, 2023
|
/backport to stable28 |
Fenn-CS
force-pushed
the
fix-open-search-result
branch
from
0710327
to
5220d89
Compare
|
/compile amend / |
ChristophWurst
approved these changes
Nov 29, 2023
nextcloud-command
force-pushed
the
fix-open-search-result
branch
from
5220d89
to
b0e4c0c
Compare
Fenn-CS
force-pushed
the
fix-open-search-result
branch
2 times, most recently
from
ab654cb
to
f639997
Compare
|
/compile amend / |
After moving the `SearchResult` to its own component and leaving out the openResult method, the search results do not lead anywhere but but error out. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix-open-search-result
branch
from
f639997
to
00bb1bc
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #41381 (comment)
After moving the
SearchResultto its own component and leaving out theopenResultmethod, the search results do not lead anywhere but but error out.