-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI updates for global search #41781
Merged
Merged
UI updates for global search #41781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenn-CS
changed the title
Improve accesibility for search tags/chips
UI updates for global search
Nov 27, 2023
Fenn-CS
force-pushed
the
minor-ui-updates-global-search
branch
from
November 27, 2023 22:40
1f27342
to
d886b51
Compare
artonge
approved these changes
Nov 28, 2023
AndyScherzinger
approved these changes
Nov 28, 2023
Fenn-CS
force-pushed
the
minor-ui-updates-global-search
branch
from
November 28, 2023 14:27
d886b51
to
2199f82
Compare
/compile amend / |
nextcloud-command
force-pushed
the
minor-ui-updates-global-search
branch
from
November 28, 2023 15:03
2199f82
to
96c945d
Compare
Fenn-CS
force-pushed
the
minor-ui-updates-global-search
branch
2 times, most recently
from
November 28, 2023 16:08
743d76a
to
4944c60
Compare
/compile amend / |
nextcloud-command
force-pushed
the
minor-ui-updates-global-search
branch
from
November 28, 2023 16:37
4944c60
to
0275298
Compare
- Use stand font of filter tags/chips - No bold - Use close icon and no close thick Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
AndyScherzinger
force-pushed
the
minor-ui-updates-global-search
branch
2 times, most recently
from
November 29, 2023 10:45
fc2cdfb
to
d972e16
Compare
/compile amend / |
1 similar comment
/compile amend / |
- Show loading when actually loading, instead of no content - Change modified label to `Date` as it applies to a bunch of things. Signed-off-by: fenn-cs <fenn25.fn@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
minor-ui-updates-global-search
branch
from
November 29, 2023 12:24
d972e16
to
1534ba0
Compare
/backport to stable28 |
/backport to stable28 |
likely will not backport because of the compiled assets. if they were in a separate commit, only those can be picked with the source changes. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#41651