Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Fix: non responsive app navigation toggle #41092

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

hamza221
Copy link
Contributor

  • Resolves: #

Summary

Screencast from 2023-10-24 18-40-13.webm
Caused by f2de58d
would appreciate other suggestions to fix this.

TODO

  • ...

Checklist

@hamza221 hamza221 requested a review from a team October 24, 2023 16:41
@hamza221 hamza221 self-assigned this Oct 24, 2023
@hamza221 hamza221 requested review from artonge, Fenn-CS and sorbaugh and removed request for a team October 24, 2023 16:41
@susnux
Copy link
Contributor

susnux commented Oct 25, 2023

@hamza221 did you forget to commit the library changes? Looks like the compiled assets contain a different version but the package.json was not updated?

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@ChristophWurst
Copy link
Member

@hamza221 did you forget to commit the library changes? Looks like the compiled assets contain a different version but the package.json was not updated?

Could also be from a compilation with old packages. E.g. no npm ci after pulling latest master.

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
@ChristophWurst ChristophWurst changed the title Fix:non responsive app navigation toggle [stable25] Fix:non responsive app navigation toggle Nov 14, 2023
@ChristophWurst ChristophWurst removed this from the Nextcloud 28 milestone Nov 14, 2023
@AndyScherzinger
Copy link
Member

@susnux @artonge can you do another review, would be nice to get the PR merged, thanks!

@ChristophWurst ChristophWurst changed the title [stable25] Fix:non responsive app navigation toggle [stable25] Fix: non responsive app navigation toggle Nov 14, 2023
@ChristophWurst ChristophWurst force-pushed the fix/non-responsive-app-navigation-toggle branch from 4c6e32f to e945b1b Compare November 16, 2023 08:09
@AndyScherzinger AndyScherzinger force-pushed the fix/non-responsive-app-navigation-toggle branch from e945b1b to a608097 Compare November 16, 2023 12:43
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2023
@blizzz blizzz force-pushed the fix/non-responsive-app-navigation-toggle branch from a608097 to 107c29b Compare November 22, 2023 20:44
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@AndyScherzinger AndyScherzinger force-pushed the fix/non-responsive-app-navigation-toggle branch from 107c29b to 6cfface Compare November 25, 2023 09:33
@blizzz blizzz merged commit 57def1e into stable25 Dec 14, 2023
30 of 31 checks passed
@blizzz blizzz deleted the fix/non-responsive-app-navigation-toggle branch December 14, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants